Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-3414 build: update ephemeral cluster #27

Closed

Conversation

avisiedo
Copy link
Contributor

@avisiedo avisiedo commented Jan 17, 2024

Update ephemeral cluster and provide more flexibility by using CLUSTER variable.

Depends on #29

@avisiedo avisiedo self-assigned this Jan 17, 2024
@app-sre-bot
Copy link

Can one of the admins verify this patch?

@avisiedo avisiedo changed the title HMS-3414 build: update ephemeral HMS-3414 build: update ephemeral cluster Jan 17, 2024
build/package/Dockerfile Outdated Show resolved Hide resolved
Comment on lines +6 to +13
COPY package*.json .
RUN npm install
COPY src src
COPY *.js .
COPY tsconfig.json tsconfig.json
RUN npm run build

COPY build/package/gen.app.info.sh gen.app.info.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about you group the copies and make their target paths explicit. This makes the src/src subdir a bit less confusing, too.

Suggested change
COPY package*.json .
RUN npm install
COPY src src
COPY *.js .
COPY tsconfig.json tsconfig.json
RUN npm run build
COPY build/package/gen.app.info.sh gen.app.info.sh
COPY package*.json /opt/app-root/src/
COPY src /opt/app-root/src/src/
COPY *.js /opt/app-root/src/
COPY tsconfig.json /opt/app-root/src/
COPY build/package/gen.app.info.sh /opt/app-root/src/
RUN npm install
RUN npm run build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point! the reason I did on this way is to take advantage of the build cache; this is useful when deploying the container in ephemeral environment, so the dependencies (npm install) will use the cache unless I change the package*.json ; so I can get a container image pushed and ready to be deployed quicker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiran ey mate! quick reminder about the conversation; would the comment above resolve the concern?

build/package/Dockerfile Outdated Show resolved Hide resolved
@avisiedo avisiedo requested a review from tiran January 18, 2024 09:25
@avisiedo avisiedo force-pushed the hms-3414-update-ephemeral branch from b6294cf to 1a813c3 Compare January 24, 2024 08:24
@avisiedo avisiedo force-pushed the hms-3414-update-ephemeral branch from 1a813c3 to 7cc3d63 Compare February 2, 2024 14:34
avisiedo and others added 12 commits February 12, 2024 12:13
Add annotation with description about the OpenShift template.

Signed-off-by: Alejandro Visiedo <[email protected]>
Just add the python dependencies to develop with the repository.

Signed-off-by: Alejandro Visiedo <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
Add the set of makefiles to provide the rules to custom deployment in
the ephemeral environment. Align this repo with the backend repository.

Signed-off-by: Alejandro Visiedo <[email protected]>
Update the alias command to run as it is specified into the platform
documentation.

Signed-off-by: Alejandro Visiedo <[email protected]>
Add a poc to try to build the frontend container locally, and check if
it could be deployed in ephemeral environment.

Signed-off-by: Alejandro Visiedo <[email protected]>
Fix wrong copy of files.

Signed-off-by: Alejandro Visiedo <[email protected]>
Add bonfire-deploy and update rule to build the container.

Signed-off-by: Alejandro Visiedo <[email protected]>
Add .dockerignore with the paths to avoid to copy to the image when the
statement 'COPY . .' is executed.

Signed-off-by: Alejandro Visiedo <[email protected]>
It was observed some differences between the container generated from
the CI/CD platform system and the container generated locally from the
repository.

This change add several changes to try to be aligned with that changes
and generate the same or similar content to what is generated by the
platform.

Signed-off-by: Alejandro Visiedo <[email protected]>
Update the ephemeral cluster and provide more flexibility to specify the
cluster to use by using the CLUSTER variable.

Co-authored-by: Christian Heimes <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
@avisiedo avisiedo force-pushed the hms-3414-update-ephemeral branch from 7cc3d63 to 4d0986d Compare February 12, 2024 11:14
@frasertweedale
Copy link
Contributor

Merged in the graph of #30.

@avisiedo avisiedo deleted the hms-3414-update-ephemeral branch April 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants