HMS-3414 build: update ephemeral cluster #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
avisiedo
changed the title
tiran
reviewed
Jan 18, 2024
Comment on lines
+6
to
+13
| COPY package*.json . | ||
| RUN npm install | ||
| COPY src src | ||
| COPY *.js . | ||
| COPY tsconfig.json tsconfig.json | ||
| RUN npm run build | ||
|
|
||
| COPY build/package/gen.app.info.sh gen.app.info.sh |
There was a problem hiding this comment.
How about you group the copies and make their target paths explicit. This makes the src/src subdir a bit less confusing, too.
Suggested change
| COPY package*.json . | |
| RUN npm install | |
| COPY src src | |
| COPY *.js . | |
| COPY tsconfig.json tsconfig.json | |
| RUN npm run build | |
| COPY build/package/gen.app.info.sh gen.app.info.sh | |
| COPY package*.json /opt/app-root/src/ | |
| COPY src /opt/app-root/src/src/ | |
| COPY *.js /opt/app-root/src/ | |
| COPY tsconfig.json /opt/app-root/src/ | |
| COPY build/package/gen.app.info.sh /opt/app-root/src/ | |
| RUN npm install | |
| RUN npm run build |
There was a problem hiding this comment.
I see your point! the reason I did on this way is to take advantage of the build cache; this is useful when deploying the container in ephemeral environment, so the dependencies (npm install) will use the cache unless I change the package*.json ; so I can get a container image pushed and ready to be deployed quicker.
There was a problem hiding this comment.
@tiran ey mate! quick reminder about the conversation; would the comment above resolve the concern?
avisiedo
force-pushed
the
hms-3414-update-ephemeral
branch
from
b6294cf to
1a813c3
Compare
avisiedo
force-pushed
the
hms-3414-update-ephemeral
branch
from
1a813c3 to
7cc3d63
Compare
Add annotation with description about the OpenShift template. Signed-off-by: Alejandro Visiedo <[email protected]>
Just add the python dependencies to develop with the repository. Signed-off-by: Alejandro Visiedo <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
Signed-off-by: Alejandro Visiedo <[email protected]>
Add the set of makefiles to provide the rules to custom deployment in the ephemeral environment. Align this repo with the backend repository. Signed-off-by: Alejandro Visiedo <[email protected]>
Update the alias command to run as it is specified into the platform documentation. Signed-off-by: Alejandro Visiedo <[email protected]>
Add a poc to try to build the frontend container locally, and check if it could be deployed in ephemeral environment. Signed-off-by: Alejandro Visiedo <[email protected]>
Fix wrong copy of files. Signed-off-by: Alejandro Visiedo <[email protected]>
Add bonfire-deploy and update rule to build the container. Signed-off-by: Alejandro Visiedo <[email protected]>
Add .dockerignore with the paths to avoid to copy to the image when the statement 'COPY . .' is executed. Signed-off-by: Alejandro Visiedo <[email protected]>
It was observed some differences between the container generated from the CI/CD platform system and the container generated locally from the repository. This change add several changes to try to be aligned with that changes and generate the same or similar content to what is generated by the platform. Signed-off-by: Alejandro Visiedo <[email protected]>
Update the ephemeral cluster and provide more flexibility to specify the cluster to use by using the CLUSTER variable. Co-authored-by: Christian Heimes <[email protected]> Signed-off-by: Alejandro Visiedo <[email protected]>
avisiedo
force-pushed
the
hms-3414-update-ephemeral
branch
from
7cc3d63 to
4d0986d
Compare
|
Merged in the graph of #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ephemeral cluster and provide more flexibility by using CLUSTER variable.
Depends on #29